removing drop_empty_siblings parameter from lsdb.from_dataframe #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
reviewed
Feb 26, 2025
Comment on lines
+65
to
+66
| #drop_empty_siblings=True | ||
| #this parameter appears to be deprecated 2/26/25 |
There was a problem hiding this comment.
Delete unnecessary lines rather than comment them out. If needed we can always go back in the git history and check on previous versions if needed.
We should have some issues for hipscat--> hats already, but by all means open a panstars specific bug report, too as I don't think the rename was meant to be done in a way to mess up existing usage. |
|
closing this because it is not necessary with PR #382 which gets rid of read_hipscat anyway in favor of read_hats |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple fix to issue #376 . The lsdb documentation says that this parameter exists, so I have opened an issue over there to ask them to clarify their documentation, and commented out this line for now in our code.
This is somewhat pointless, because making this fix then allows me to run the code and realize that the panstarrs module doesn't work at all anymore because hipscat is apparently not a thing anymore. I will open a new issue for that.